Skip to content

More Robust Tests 🧪 #41

@GrantBirki

Description

@GrantBirki

This issue tracks work to bring even more robust tests to this project.

For a while now, a lot of issues/bugs have been popping up (that I haven't had the time to dig into) which are almost certainly due to the fact that this project lacks in-depth testing of edge cases. There are so many ways users can interact with this action and what the state of the "git diff" can be that this Action is trying to parse. This project has tests, but we need so many more to have more confidence in making changes and not making bugs.

The following needs to be done:

  • More unit tests covering more edge cases
  • Increase test coverage of "branches" (we don't test all branches of code today even though we have 100% line coverage)
  • More real world test cases
  • More tests that might cover edge cases with
    • Using the search_path input option
    • Using the git_options input option
    • Using the git_diff_file input option
    • Using the max_buffer_size input option
  • More tests with the shape/size/contents of a git diff that gets passed into this action. We already have fixtures (examples) around this but we need a lot more, and they need to cover all edge cases that we can think of.
  • Look for bugs or possible issues along the way when writing these tests
  • Fix those bugs
  • Write tests around any bug fixes
  • Look for easy wins where we could make the code more maintainable without breaking existing logic

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions