feat: add universal2 arch for macos builds#281
Merged
GrahamDumpleton merged 1 commit intoGrahamDumpleton:developfrom Jan 14, 2025
Merged
feat: add universal2 arch for macos builds#281GrahamDumpleton merged 1 commit intoGrahamDumpleton:developfrom
GrahamDumpleton merged 1 commit intoGrahamDumpleton:developfrom
Conversation
b1d94cd to
5708baf
Compare
Owner
|
This is what GitHub actions produces now when do a test run. Is this what you expect? What are the benefits/requirement for having a universal wheel for macOS? I wasn't aware such a thing existed before you pointed it out. |
Contributor
Author
|
@GrahamDumpleton the benefit is that the wheel runs on both architecture types for macos so there's no need to have individual The importance here is that this package |
Owner
|
Try |
Contributor
Author
|
@GrahamDumpleton this is great thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GrahamDumpleton I realized that what I needed was a
universal2binary forwrapton macos. I made a PR on my fork here which should have what you need to approve, but let me know if this works for you