Encode transformed properties files with specified Charset#819
Merged
johnrengelman merged 2 commits intoGradleUp:masterfrom Mar 20, 2023
Merged
Conversation
f120f4b to
d214b6f
Compare
Currently, the content from any properties file that is passed through the `PropertiesFileTransformer` will have its output written into the jar encoded as `ISO_8859_1`. If the source file contains UTF-8 content, the output becomes corrupted. This commit allows the buildscript to define the Charset to perform the transformation with.
d214b6f to
9bffd1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the content from any properties file that is passed through the
PropertiesFileTransformerwill have its output written into the jar encoded asISO_8859_1. If the source file contains UTF-8 content, the output becomes corrupted.This commit allows the buildscript to define the Charset to perform the transformation with.
Resolves #818