Skip to content

Fix the plugin dependency identifier in the docs#754

Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom
lnhrdt:fix-docs-plugin-identifier
Feb 15, 2022
Merged

Fix the plugin dependency identifier in the docs#754
johnrengelman merged 1 commit intoGradleUp:masterfrom
lnhrdt:fix-docs-plugin-identifier

Conversation

@lnhrdt
Copy link
Copy Markdown
Contributor

@lnhrdt lnhrdt commented Feb 12, 2022

Fixes the instructions for adding the Gradle plugin to the buildscript classpath in the user guide.

Based on the instructions in the Gradle plugin portal:
https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow

Fixes #750.

@tajchert
Copy link
Copy Markdown

This is a good change thank you :) I didn't realize and it took me a while to find source of my problem

@johnrengelman johnrengelman merged commit 24c371c into GradleUp:master Feb 15, 2022
@LIMPIX31
Copy link
Copy Markdown

LIMPIX31 commented Aug 7, 2022

Nice

@lnhrdt
Copy link
Copy Markdown
Contributor Author

lnhrdt commented Mar 9, 2023

Hey @johnrengelman! I'm upgrading to 8.1.0 finally and finding the configuration shown in the docs broken again. Not sure why it keeps changing but maybe you do!

Right now your docs suggest this to add the plugin to the buildscript classpath:

buildscript {
    repositories {
        gradlePluginPortal()
    }
    dependencies {
        classpath 'gradle.plugin.com.github.johnrengelman:shadow:8.1.0'
    }
}

but the correct configuration (found on Gradle's plugin site) suggest:

buildscript {
  repositories {
    maven {
      url = uri("https://plugins.gradle.org/m2/")
    }
  }
  dependencies {
    classpath("com.github.johnrengelman:shadow:8.1.0")
  }
}

Maybe just link to the Gradle site from your docs? Or maybe you know why your published artifact IDs have been changing?

@lnhrdt lnhrdt deleted the fix-docs-plugin-identifier branch March 9, 2023 02:33
@lnhrdt lnhrdt restored the fix-docs-plugin-identifier branch March 9, 2023 02:33
@johnrengelman
Copy link
Copy Markdown
Collaborator

They’ve been changing because Gradles been changing how plugins are published (first with bintray going away and then some other internal stuff)
I need to publish a bit about the. Testing change in the recent version, life got in the way.
good thought on just linking out. (Most people should just use the plugin method instead of declaring the dependency directly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin vanishing again Plugin [id: 'com.github.johnrengelman.shadow', version: '7.1.2'] was not found

4 participants