Support for Toolchains for JVM Projects#691
Closed
rpalcolea wants to merge 2 commits intoGradleUp:masterfrom
Closed
Support for Toolchains for JVM Projects#691rpalcolea wants to merge 2 commits intoGradleUp:masterfrom
rpalcolea wants to merge 2 commits intoGradleUp:masterfrom
Conversation
… order to leverage Toolchains. Fixes GradleUp#690
Collaborator
|
Rebased and merged in 629114a |
Contributor
Author
|
awesome @johnrengelman , thanks! do you have plans to release this soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #690
Similarly to Application Plugin, the
ShadowApplicationPluginshould configure thejavaLauncherin order to leverage ToolchainsI created this change on top of #672 to avoid duplicated efforts to fix the tests suite