Add input/output annotations to transformers#646
Closed
wolfs wants to merge 7 commits intoGradleUp:masterfrom
Closed
Add input/output annotations to transformers#646wolfs wants to merge 7 commits intoGradleUp:masterfrom
wolfs wants to merge 7 commits intoGradleUp:masterfrom
Conversation
da350bc to
206ce6e
Compare
so that the transformer remain compatible with Gradle 7.0. In Gradle 7.0 missing annotations on input properties will fail the build. Input properties include properties on `@Nested` inputs, which includes all the Transformers.
206ce6e to
75478c5
Compare
Contributor
|
I hadn't seen this before. Interesting that we came up with very similar solutions independently (#647). I believe you beat me to it with the time I spent figuring out why the test was not working for I think the main differences are:
|
Contributor
Author
|
@helfper I looked at your PR and it looks good! I left some comments regarding the annotations. I still would like to salvage the changes I did here to assert that no test has any deprecation warnings. I'll extract this into another PR and then close this one. Or do you prefer that I base this PR on top of yours? |
Merged
Contributor
Author
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that the transformer remain compatible with Gradle 7.0.
In Gradle 7.0 missing annotations on input properties will fail the build. Input properties include properties on
@Nestedinputs, which includes all theTransformers.