ensure input stream is closed when remapping classes#587
Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom Oct 5, 2020
Merged
ensure input stream is closed when remapping classes#587johnrengelman merged 1 commit intoGradleUp:masterfrom
johnrengelman merged 1 commit intoGradleUp:masterfrom
Conversation
Contributor
Author
|
@johnrengelman it's been a couple months. Are you able to look at this or is there another authorized contributor? |
Armaxis
approved these changes
Sep 28, 2020
Contributor
Armaxis
left a comment
There was a problem hiding this comment.
Thanks for fixing this! We've stumbled upon the same leak, and this fix worked!
Previously, the number of opened file descriptors climbed all the way to 10k, unless GC kicked off and closed those. Occasionally this cause a crash as described.
With this fix the number of opened file descriptors is stabilized around 1470 👍
@johnrengelman can we please have this fix included in next release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more time, @johnrengelman. I hope this solves once and for all the input stream issue that has plagued us over the years trying to stay current on Gradle. Please take a look - I'm not sure how you would approach testing this since it would require enough remapped classes to open sufficiently many files.
Note the culprit of our build failure this time is: https://github.com/johnrengelman/shadow/blob/master/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.groovy#L331
My exception (not present with the fix):