Skip to content

Eliminate serviceEntries deprecation warning by making it private#569

Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom
newrelic-forks:jalder/fix-servicedetails
May 23, 2020
Merged

Eliminate serviceEntries deprecation warning by making it private#569
johnrengelman merged 1 commit intoGradleUp:masterfrom
newrelic-forks:jalder/fix-servicedetails

Conversation

@jeffalder
Copy link
Copy Markdown
Contributor

@jeffalder jeffalder commented Apr 30, 2020 •
edited
Loading

Fixes #530

I ran a test between HEAD and this:

% ./gradlew --warning-mode=all shadowJar
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :shadowJar
Property 'transformers.$0.serviceEntries' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.

BUILD SUCCESSFUL in 30s
2 actionable tasks: 2 executed
  • this change:
% ./gradlew --warning-mode=all shadowJar

BUILD SUCCESSFUL in 6s
2 actionable tasks: 1 executed, 1 up-to-date

I also verified that the contents of the META-INF/services files were the same. I also ran an incremental build (first clean shadowJar then shadowJar) and the result was the same.

@jeffalder
Copy link
Copy Markdown
Contributor Author

jeffalder commented Apr 30, 2020

@johnrengelman It ... just works? It looks like a transient variable, so I marked it private. There's a test that references it that seems to be passing so 🤷

@jeffalder jeffalder changed the title Fixes #530 : private values are not checked for annotations Eliminate serviceEntries deprecation warning by making it private Apr 30, 2020
@johnrengelman johnrengelman merged commit e94a04f into GradleUp:master May 23, 2020
@jeffalder jeffalder deleted the jalder/fix-servicedetails branch July 24, 2020 21:13
@helfper helfper mentioned this pull request Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gradle 6 deprecation warnings

2 participants

@jeffalder @johnrengelman