Skip to content

Upgrade to ASM 7.3.1 to support JDK 15#549

Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom
vyazelenko:master
Mar 7, 2020
Merged

Upgrade to ASM 7.3.1 to support JDK 15#549
johnrengelman merged 1 commit intoGradleUp:masterfrom
vyazelenko:master

Conversation

@vyazelenko
Copy link
Copy Markdown
Contributor

@johnrengelman Any estimate on when the next version of the Shadow plugin will be released?

@johnrengelman johnrengelman merged commit 93e417f into GradleUp:master Mar 7, 2020
@johnrengelman johnrengelman added this to the 6.0 milestone Mar 7, 2020
@VoxelGod
Copy link
Copy Markdown

VoxelGod commented Jun 17, 2020

Unfortunately, a JDK 14 and 15 preview feature (records) requires ASM 8. I haven't tested instanceof pattern matching.

* What went wrong:
Execution failed for task ':shadowJar'.
> Records requires ASM8

@johnrengelman
Copy link
Copy Markdown
Collaborator

@VoxelGod
Copy link
Copy Markdown

@johnrengelman One of my colleagues inspected the stacktrace (https://hastebin.com/egemarucaw.txt) and found ASM7 references in jdependency to be responsible:
https://github.com/tcurdt/jdependency/blob/c2e760c533225d313c5ef8e1d1f14840591bf431/src/main/java/org/vafer/jdependency/asm/DependenciesClassAdapter.java#L128

I can notify them of the issue, then jdependency would need to be updated in ShadowJar as well.

@johnrengelman
Copy link
Copy Markdown
Collaborator

Looks like jdependency 2.4.0 uses ASM 8

@VoxelGod
Copy link
Copy Markdown

Is it possible this dependency update could be targeted for a minor release in the future? For now, I'll exclude records from my project.

@bridgettewp
Copy link
Copy Markdown

bridgettewp commented Jun 19, 2020

Encountering the same issue with JDK 14 preview features. Records throw a TaskExecutionException. Relocation and minimization do work now, though.

Just confirmed instanceof pattern matching does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants