Add ManifestAppenderTransformer to support sealing packages in jars.#474
Merged
johnrengelman merged 3 commits intoGradleUp:masterfrom Jun 29, 2019
Merged
Conversation
Contributor
Author
|
BTW, can this plugin be installed into a local repository? I would like to test it properly on an actual project 😉. |
eef7c0c to
eaa8a90
Compare
b626534 to
a091d0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java's manifest attributes are implemented using a
HashMap, which makes them useless when the attributes must be written in a particular order. E.g. for sealing packages in jars:Implement a
Transformerwhich can append tags to a manifest while preserving their order.Note: This is a WIP - my transformer's current UI is based on Groovy'sTuple2. However, I'm sure that Groovy can support something better.The transformer's current API is:
shadowJar { transform(ManifestAppenderTransformer) { append('Name', 'first/sealed/package/') append('Sealed', true) append('Name', 'second/sealed/package/') append('Sealed', true) } }