Skip to content

Take into account api scope on minimization#405

Merged
johnrengelman merged 11 commits intoGradleUp:masterfrom
osipxd:feature/api-scope-on-minimization
Oct 27, 2018
Merged

Take into account api scope on minimization#405
johnrengelman merged 11 commits intoGradleUp:masterfrom
osipxd:feature/api-scope-on-minimization

Conversation

@osipxd
Copy link
Copy Markdown
Contributor

@osipxd osipxd commented Oct 1, 2018

This pull request fixes the case when we use minimize() in the project that have api scoped dependencies.

Dependencies scoped as api will be:

  • excluded from minimization
  • added to "project classes" (to avoid the case when dependencies used in API was removed on minimization)

@osipxd osipxd force-pushed the feature/api-scope-on-minimization branch from 2483b05 to e75852a Compare October 1, 2018 08:04
@osipxd osipxd force-pushed the feature/api-scope-on-minimization branch from e75852a to 9a286f2 Compare October 1, 2018 08:05
Copy link
Copy Markdown
Collaborator

@johnrengelman johnrengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I should be able to get a new release out in the next couple of days.

@johnrengelman johnrengelman merged commit 7aa748e into GradleUp:master Oct 27, 2018
@johnrengelman johnrengelman added this to the 4.0.2 milestone Oct 27, 2018
@osipxd osipxd deleted the feature/api-scope-on-minimization branch October 28, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants