Change the group of startShadowScripts from application to other#1797
Merged
Change the group of startShadowScripts from application to other#1797
startShadowScripts from application to other#1797Conversation
group of startShadowScriptsstartShadowScripts from application to other
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the group assignment of the startShadowScripts task from application to other to align with how Gradle's ApplicationPlugin handles similar tasks.
- Removes the explicit group assignment for
startShadowScriptstask, allowing it to default toother - Updates test expectations to reflect the group change
- Adds changelog entry documenting the change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt | Removes explicit APPLICATION_GROUP assignment from startShadowScripts task |
| src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt | Updates test to remove group assertion for startShadowScripts and adds import for APPLICATION_GROUP |
| docs/changes/README.md | Documents the change in the unreleased changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cca591e to
c0824e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns with https://github.com/gradle/gradle/blob/fdecc3c95828bb9a1c1bb6114483fe5b16f9159d/platforms/jvm/plugins-application/src/main/java/org/gradle/api/plugins/ApplicationPlugin.java#L183