Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression where registering ShadowJar tasks without applying the ShadowPlugin would fail. The fix ensures the shadow configuration is safely accessed using findByName instead of direct property access.
- Change shadow configuration access to use safe lookup instead of direct property access
- Add comprehensive functional test to verify ShadowJar tasks work without Shadow plugin applied
- Update helper method to support testing scenarios without Shadow plugin
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ShadowJar.kt | Replace direct shadow configuration access with safe lookup using findByName |
| JavaPluginsTest.kt | Add functional test verifying ShadowJar task registration without Shadow plugin |
| BasePluginTest.kt | Add parameter to control Shadow plugin application in test helper method |
| README.md | Update changelog with fix description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1784.