Document embedding non-JAR dependencies#1777
Merged
Merged
Conversation
Goooler
commented
Sep 23, 2025
Member
- Closes Update to from "8.1.1" to "9.1.0" leads to "Cannot expand ZIP .... .pom" #1716.
- Closes Cannot expand ZIP: *.pom, java.util.zip.ZipException: Archive is not a ZIP archive #1776.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation and tests for embedding non-JAR dependencies into shadowed JARs. It addresses scenarios where remote dependencies are not JAR files (e.g., POM files, native libraries) that cause build failures when included in standard runtime configurations.
- Adds functional test for custom configuration handling of non-JAR dependencies
- Documents solution using custom configurations with
from()method to avoid ZIP expansion errors - Updates cross-references between documentation sections
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginsTest.kt |
Adds test case verifying non-JAR dependencies can be embedded via custom configuration |
docs/configuration/dependencies/README.md |
Documents new section on embedding non-JAR dependencies with code examples |
docs/configuration/README.md |
Adds cross-reference link to new documentation section |
Goooler
commented
Sep 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.