Allow overriding BUNDLING_ATTRIBUTE in GMM#1773
Merged
Goooler merged 12 commits intoGradleUp:mainfrom Sep 24, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Goooler
reviewed
Sep 20, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowExtension.kt
Outdated
Show resolved
Hide resolved
74ea7a2 to
d50fb88
Compare
Contributor
Author
|
After thinking on your comments, I went ahead with a different approach, one that defaults to |
```kotlin
tasks.shadow {
// Unsetting automatically uses `Bundling.EMBEDDED` attribute if and only if there is no relocation.
bundlingAttribute = null
// Setting manually forces that attribute to be used instead.
bundlingAttribute = 'embedded'
}
```
8299e1e to
167e94b
Compare
Goooler
reviewed
Sep 21, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Sep 21, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Outdated
Show resolved
Hide resolved
Member
You can add a new test ref the others in Also needs an extra check in |
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
Goooler
reviewed
Sep 21, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Sep 23, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
Outdated
Show resolved
Hide resolved
Bundling.EMBEDDED for non-relocating shadow JARsBUNDLING_ATTRIBUTE in GMM
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for overriding the BUNDLING_ATTRIBUTE in Gradle Module Metadata (GMM) for shadow JARs through a new bundlingAttribute property in the ShadowExtension.
- Introduces a new
bundlingAttributeproperty inShadowExtensionwith default valueBundling.SHADOWED - Updates the attribute setting logic to use
attributeProviderwith lazy evaluation - Adds comprehensive tests and documentation for the new feature
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowExtension.kt | Adds the new bundlingAttribute property definition |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowBasePlugin.kt | Sets the default convention value for the bundling attribute |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt | Updates attribute configuration to use the new property with lazy evaluation |
| src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt | Adds test assertion for the default bundling attribute value |
| src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/PublishingTest.kt | Adds functional test for overriding the bundling attribute |
| docs/publishing/README.md | Documents the new feature with usage examples |
| docs/changes/README.md | Updates changelog with the new feature |
| api/shadow.api | Updates public API surface with new method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
33e682c to
3d71dc5
Compare
3d71dc5 to
6b1d10e
Compare
Goooler
approved these changes
Sep 24, 2025
Contributor
Author
|
Thanks for finishing this up for me. I ended up having a busy start to my week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundling.EMBEDDED#1767.Adds a new property to the
ShadowJartask that dictates the bundling type to be used for the consumable configuration. I'm adding the bundling attribute usingAttributeContainer#attributeProvideras lazily-added attribute aren't computed until they're needed, which is after project evaluation.Once again looking for help with tests and code cleanup like last time. Kotlin is not my primary language 😅
tasks.shadowJar { bundlingAttribute = 'embedded' }