Default duplicatesStrategy back to EXCLUDE#1617
Merged
Conversation
fc96682 to
a86339b
Compare
5e6bc2c to
99e0c76
Compare
c9bb622 to
91ba8ed
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the default duplicatesStrategy for the ShadowJar task from INCLUDE back to EXCLUDE, restoring compatibility with 8.x series behavior. This change affects how duplicate files are handled when merging JARs, with EXCLUDE keeping only the first occurrence of duplicate files.
- Changes the default
duplicatesStrategyfromINCLUDEtoEXCLUDEin the ShadowJar task - Updates documentation and comments to reflect the new default behavior
- Modifies test configurations to explicitly set
INCLUDEwhere needed for ResourceTransformers
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ShadowJar.kt | Changes default duplicatesStrategy to EXCLUDE and updates related documentation comments |
| ServiceFileTransformerTest.kt | Adds explicit EXCLUDE strategy setting to maintain test behavior |
| BaseTransformerTest.kt | Sets INCLUDE strategy in base test setup for transformer compatibility |
| JavaPluginsTest.kt | Updates test assertions and configurations to reflect new default |
| docs/configuration/merging/README.md | Updates documentation to reflect EXCLUDE as the new default |
| docs/changes/README.md | Adds changelog entry documenting the breaking change |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Does DuplicatesStrategy.WARN behaves as DuplicatesStrategy.INCLUDE or DuplicatesStrategy.EXCLUDE ? The doc comment still say: |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.