Fix the regression of resolving circular dependencies in MinimizeDependencyFilter#1611
Merged
Fix the regression of resolving circular dependencies in MinimizeDependencyFilter#1611
MinimizeDependencyFilter#1611Conversation
e702707 to
2186622
Compare
This reverts commit 2186622.
This was referenced Aug 8, 2025
MinimizeDependencyFilter
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the MinimizeDependencyFilter class that was causing issues with circular dependency handling during minimization. The fix ensures that dependency resolution only continues for dependencies that were successfully added to the included set.
- Fixed the logic in
MinimizeDependencyFilter.resolve()to only recurse on children when a dependency is actually included - Added a functional test to verify circular dependency exclusion works correctly
- Updated the changelog to document the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.kt |
Fixed recursion logic to only process children of included dependencies |
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/MinimizeTest.kt |
Added test case for circular dependency exclusion scenario |
docs/changes/README.md |
Updated changelog with fix description |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.kt
Show resolved
Hide resolved
MinimizeDependencyFilterMinimizeDependencyFilter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.