Add functional tests for PropertiesFileTransformer#1485
Merged
Conversation
0b70c71 to
59008c5
Compare
59008c5 to
38f28d4
Compare
38f28d4 to
28b0c2b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds functional tests for the PropertiesFileTransformer, ensuring various merge strategies, key transformations, charset handling, mappings, and removal of the default timestamp header.
- Documented
CleanPropertiesbehavior with KDoc - Removed the generic
PropertiesFileTransformerentry from the shared transformer matrix - Added a new
PropertiesFileTransformerTestsuite covering multiple scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.kt | Added KDoc explaining suppression of the timestamp header |
| src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/TransformersTest.kt | Removed the PropertiesFileTransformer case from the matrix |
| src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerTest.kt | Introduced functional tests for PropertiesFileTransformer |
Comments suppressed due to low confidence (2)
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.kt:10
- [nitpick] The KDoc summary is a bit vague; consider clarifying that this class overrides
storeto suppress the default date comment header, for example: "CleanProperties overridesstoreto prevent writing the timestamp comment."
* Introduced in order to remove prepended timestamp when creating output stream.
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/TransformersTest.kt:197
- Removing the PropertiesFileTransformer entry from the generic transformer matrix may leave its core behavior (especially
keyTransformerlogic) untested at that level; ensure these scenarios are fully covered by the new functional tests.
"" to ManifestResourceTransformer::class,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs