Merged
Conversation
Goooler
commented
Jun 18, 2025
| } else { | ||
| @Suppress("DEPRECATION") | ||
| dependencyProject | ||
| return this::class.java.getDeclaredMethod("getDependencyProject").invoke(this) as Project |
Comment on lines
-333
to
+332
| throw UncheckedIOException("Unable to create ZIP output stream for file $destination.", e) | ||
| throw IOException("Unable to create ZIP output stream for file $destination.", e) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to Gradle 9.0.0 RC1 with corresponding changes in the ShadowJar task and Gradle compatibility logic. Key changes include:
- Changing the thrown exception in ShadowJar from an unchecked to a checked exception.
- Replacing a deprecated property with a reflection-based method call in GradleCompat.
- Updating the Gradle wrapper distribution URL and related lint baseline settings.
- Adjusting the gradlew copyright header.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt | Changes exception type for ZIP output stream errors |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/GradleCompat.kt | Replaces deprecated dependency lookup with reflection |
| gradlew | Updates copyright header |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle distribution to 9.0.0-rc-1 |
| gradle/lint-baseline.xml | Aligns lint baseline version and locations with changes |
Comments suppressed due to low confidence (3)
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt:332
- Changing from UncheckedIOException to IOException alters the method's exception contract; ensure that all callers are updated to explicitly handle this checked exception.
throw IOException("Unable to create ZIP output stream for file $destination.", e)
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/GradleCompat.kt:107
- The reflection call does not include error handling for potential method lookup failures; consider wrapping it in a try-catch block to manage reflective operation exceptions gracefully.
return this::class.java.getDeclaredMethod("getDependencyProject").invoke(this) as Project
gradlew:4
- [nitpick] Please verify that changing the copyright notice from a range to a single year is intentional and aligns with the project's documentation standards.
# Copyright © 2015 the original authors.
This reverts commit 7b630d7.
Member
Author
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.gradle.org/9.0.0-rc-1/release-notes.html