Conversation
There was a problem hiding this comment.
Code Review
The pull request adds documentation for the duplicatesStrategy property in the ShadowJar task. The documentation provides a good overview of the available strategies and how to configure them. However, there are a few minor issues that could be improved.
Merge Readiness
The code changes are generally well-done and the documentation is helpful. I would recommend addressing the minor issues before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new documentation section detailing how the ShadowJar task handles duplicate files according to the duplicatesStrategy property.
- Introduces an explanation of various duplicate handling strategies (EXCLUDE, FAIL, INCLUDE, INHERIT, WARN).
- Provides Kotlin and Groovy code snippets for configuring the duplicatesStrategy in ShadowJar tasks.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR documents the handling of duplicates in ShadowJar by introducing a dedicated section on DuplicatesStrategy.
- Added a new "Handling Duplicates Strategy" section with detailed descriptions of the available strategies.
- Provided Kotlin and Groovy code examples that demonstrate how to override the default duplicatesStrategy.
- Updated the explanation of how different strategies affect the final JAR content.
Closes #520.