Code Review

The pull request updates the dependency resolution logic in AbstractDependencyFilter.kt to handle Provider and DependencyValueSource types. This change aims to improve the flexibility of dependency filtering. The addition to lint-baseline.xml suppresses a lint error related to internal Gradle API usage.

Summary of Findings

• Internal Gradle API Usage: The code introduces a dependency on org.gradle.api.internal.catalog.DependencyValueSource, which is an internal Gradle API. While the lint baseline is updated to suppress the warning, it's crucial to understand the implications of using internal APIs, as they are subject to change without notice and can break the plugin in future Gradle versions. Consider if there are public APIs that can achieve the same result.
• Nullability of dependencyNotation.obtain(): The code uses requireNotNull(dependencyNotation.obtain()). While this prevents a potential NullPointerException, it would be useful to understand the conditions under which dependencyNotation.obtain() can return null, and whether a more graceful handling mechanism is possible.

Merge Readiness

The pull request introduces changes that touch internal Gradle APIs. While the immediate functionality might be correct, the long-term maintainability and compatibility with future Gradle versions should be carefully considered. Given the use of internal APIs, I recommend a thorough review by someone with deep knowledge of Gradle internals. I am unable to approve this pull request, and recommend that others review and approve this code before merging. At a minimum, the high severity issue should be addressed before merging.

PR Overview

This PR adds support for using type-safe dependency accessors in ShadowJar.dependencies, as noted in the changelog update.

• Introduces a changelog entry for the new feature.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.