-
-
Notifications
You must be signed in to change notification settings - Fork 423
Legacy plugin application order breaks shadow detection logic updated for new id #964
Copy link
Copy link
Closed
Labels
Description
Expected and Results
I expect to be able to upgrade from 8.3.0 to 8.3.1 without errors.
Instead, I get this:
* What went wrong:
An exception occurred applying plugin request [id: 'com.gradleup.shadow']
> Failed to apply plugin class 'com.github.jengelman.gradle.plugins.shadow.legacy.LegacyShadowPlugin'.
> Task with name 'shadowJar' not found in project ':minimotd-fabric'.
This is because my plugin quiet-loom is checking for all 3 shadow IDs: https://github.com/jpenilla/quiet-loom/blob/071311814f91e5b1409d5008976968da2dc60180/patches/architectury-loom/0006-Detect-shadowJar.patch
I think this could be fixed by applying the empty legacy plugin after plugins that register the shadowJar task.
Related environent and versions
No response
Reproduction steps
Have logic expecting shadowJar task to be registered inside of a plugins.withId action for the legacy plugin id.
Anything else?
No response
Reactions are currently unavailable