-
-
Notifications
You must be signed in to change notification settings - Fork 423
Ant should be api, not implementation dependency #1487
Copy link
Copy link
Closed
Labels
Description
Expected and Results
Currently com.github.jengelman.gradle.plugins.shadow.transformers.Transformer is a public interface, and it has modifyOutputStream(os: org.apache.tools.zip.ZipOutputStream, preserveFileTimestamps: Boolean) method which exposes ant interface tools.zip.ZipOutputStream.
I suggest ant should be on the api scope, so the consumers can implement Transformer:
Line 104 in 68c9f64
| implementation(libs.apache.ant) |
An alternative option would be replacing the parameter with java.util.zip.ZipOutputStream so ant is not needed.
Related environment and versions
No response
Reproduction steps
No response
Anything else?
No response
Reactions are currently unavailable