Skip to content

Commit 8eeb64e

Browse files
authored
Expose Ant as compile scope (#1488)
As `org.apache.tools.zip.ZipOutputStream` is exposed in the public APIs: ```api public class com/github/jengelman/gradle/plugins/shadow/transformers/DontIncludeResourceTransformer : com/github/jengelman/gradle/plugins/shadow/transformers/ResourceTransformer { public fun modifyOutputStream (Lorg/apache/tools/zip/ZipOutputStream;Z)V ... } ``` View the scope changes: ```diff diff --color=auto -r before/shadow-gradle-plugin-9.0.0-SNAPSHOT.module after/shadow-gradle-plugin-9.0.0-SNAPSHOT.module 27a28,36 > "dependencies": [ > { > "group": "org.apache.ant", > "module": "ant", > "version": { > "requires": "1.10.15" > } > } > ], 85,91d93 < "group": "org.apache.ant", < "module": "ant", < "version": { < "requires": "1.10.15" < } < }, < { 137a140,146 > } > }, > { > "group": "org.apache.ant", > "module": "ant", > "version": { > "requires": "1.10.15" diff --color=auto -r before/shadow-gradle-plugin-9.0.0-SNAPSHOT.pom after/shadow-gradle-plugin-9.0.0-SNAPSHOT.pom 40c40 < <scope>runtime</scope> --- > <scope>compile</scope> ```
1 parent 68c9f64 commit 8eeb64e

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ publishing.publications.withType<MavenPublication>().configureEach {
101101

102102
dependencies {
103103
compileOnly(libs.kotlin.kmp)
104-
implementation(libs.apache.ant)
104+
api(libs.apache.ant) // Types from Ant are exposed in the public API.
105105
implementation(libs.apache.commonsIo)
106106
implementation(libs.apache.log4j)
107107
implementation(libs.asm)

docs/changes/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## [Unreleased](https://github.com/GradleUp/shadow/compare/9.0.0-beta17...HEAD) - 2025-xx-xx
44

5+
**Changed**
6+
7+
- Expose Ant as compile scope. ([#1487](https://github.com/GradleUp/shadow/pull/1487))
58

69
## [9.0.0-beta17](https://github.com/GradleUp/shadow/releases/tag/9.0.0-beta17) - 2025-06-18
710

0 commit comments

Comments
 (0)