Fix: Ensure AutoDetectMkvToolnixPath runs when MKVToolnix Path is empty. For #28#29
Merged
Conversation
if MkvToolnixPath is empty, force detect path of mmg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When gMKVExtractGUI is started directly, the detection of
mmg/mkvmerge.exeis skipped ifMKVToolnix Pathin the.inifile is empty._Settings.MkvToolnixPathis empty, the existence check falls back to the current working directory.mkvmerge.exe, so it is detected.mkvmerge.exeis not found.AutoDetectMkvToolnixPathis skipped entirely, leading to failure to detect MKVToolnix.Root Cause
MKVToolnix Pathbeing empty in the.inifile.Solution
Before performing the detection checks, explicitly verify that
_Settings.MkvToolnixPathis not empty or whitespace.AutoDetectMkvToolnixPathto run.This ensures consistent detection regardless of how the program is started.