Refactor gMKVInfom, fix typos and improve parsing#14
Merged
Conversation
Updated constructor parameter names for `gMKVExtract` and `gMKVInfo` to correct a typo. Added new regular expressions for parsing timecodes and timestamps in `gMKVInfo`. Changed `_VideoTrackDelay` to use `int.MinValue` for consistency and made `_Version` readonly. Simplified segment handling in `GetMKVSegments` and refactored track delay logic for better readability. Streamlined version parsing and standardized logging format. Introduced a static dictionary for mapping `MkvInfoOptions` to string representations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor gMKVInfom, fix typos and improve parsing
Updated constructor parameter names for
gMKVExtractandgMKVInfoto correct a typo.Added new regular expressions for parsing timecodes and timestamps in
gMKVInfo.Changed
_VideoTrackDelayto useint.MinValuefor consistency and made_Versionreadonly.Simplified segment handling in
GetMKVSegmentsand refactored track delay logic for better readability.Streamlined version parsing and standardized logging format.
Introduced a static dictionary for mapping
MkvInfoOptionsto string representations.