Template Animations: Added zoom and fade animations#962
Merged
BrittanyIRL merged 1 commit intomasterfrom Apr 7, 2020
Merged
Conversation
Contributor
|
Size Change: 0 B Total Size: 513 kB ℹ️ View Unchanged
|
| return useContainer ? ( | ||
| <div | ||
| style={{ | ||
| clipPath: 'inset(0)', |
Contributor
Author
There was a problem hiding this comment.
The use of clipPath here is simply clipping the container similar to adding overflow: hidden.
BrittanyIRL
approved these changes
Apr 2, 2020
Contributor
BrittanyIRL
left a comment
There was a problem hiding this comment.
This zoom animation is tight!
LGTM, works great. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds in zoom and fade animations. It also re-introduces the idea of letting our animations have container divs if need be (I needed it for zoom).
Zoom in:
Zoom out:
Fade out:
Fade in:
