Skip to content

Remove fallback publisher logo#4787

Merged
swissspidy merged 11 commits intomainfrom
fix/publisher-logo
Oct 6, 2020
Merged

Remove fallback publisher logo#4787
swissspidy merged 11 commits intomainfrom
fix/publisher-logo

Conversation

@spacedmonkey
Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey commented Oct 2, 2020

Summary

Remove fallback publisher logo and placeholder.

Relevant Technical Choices

Remove existing placeholder images and remove empty attribute.

To-do

User-facing changes

Testing Instructions

Fixes #4762

@google-cla google-cla bot added the cla: yes label Oct 2, 2020
@spacedmonkey spacedmonkey added Pod: WP & Infra Type: Infrastructure Changes impacting testing infrastructure or build tooling labels Oct 2, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2020 •
edited
Loading

Size Change: -28 B (0%)

Total Size: 1.35 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 909 B 0 B
assets/css/stories-dashboard.css 939 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/chunk-fonts-********************.js 43.5 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 9.97 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.83 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 9.87 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 9.75 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 4.38 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 4.8 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 3.63 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 3.82 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 4.47 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 4.2 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 7.37 kB 0 B
assets/js/edit-story.js 517 kB -12 B (0%)
assets/js/stories-dashboard.js 582 kB -16 B (0%)
assets/js/web-stories-activation-notice.js 74 kB 0 B
assets/js/web-stories-embed-block.js 17.5 kB 0 B

compressed-size-action

@spacedmonkey spacedmonkey mentioned this pull request Oct 2, 2020
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #4787 into main will increase coverage by 39.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4787       +/-   ##
===========================================
+ Coverage   35.45%   75.06%   +39.60%     
===========================================
  Files         715      888      +173     
  Lines       12680    15517     +2837     
===========================================
+ Hits         4496    11648     +7152     
+ Misses       8184     3869     -4315
Flag Coverage Δ
#karmatests 52.69% <ø> (+24.02%) ⬆️
#unittests 65.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sets/src/activation-notice/app/components/image.js 100.00% <ø> (ø)
...ssets/src/activation-notice/app/components/link.js 100.00% <ø> (ø)
...activation-notice/app/components/messageContent.js 0.00% <ø> (ø)
.../src/activation-notice/app/components/paragraph.js 100.00% <ø> (ø)
...sets/src/activation-notice/app/components/step1.js 87.50% <ø> (ø)
...sets/src/activation-notice/app/components/step2.js 85.71% <ø> (ø)
...sets/src/activation-notice/app/components/step3.js 85.71% <ø> (ø)
...activation-notice/app/components/successMessage.js 91.66% <ø> (ø)
assets/src/activation-notice/app/index.js 0.00% <ø> (ø)
assets/src/activation-notice/index.js 0.00% <ø> (ø)
... and 837 more

swissspidy
swissspidy reviewed Oct 2, 2020
View reviewed changes
swissspidy
swissspidy reviewed Oct 2, 2020
View reviewed changes
spacedmonkey
spacedmonkey commented Oct 5, 2020
View reviewed changes
spacedmonkey
spacedmonkey commented Oct 5, 2020
View reviewed changes
spacedmonkey
spacedmonkey commented Oct 5, 2020
View reviewed changes
@spacedmonkey spacedmonkey marked this pull request as ready for review October 5, 2020 15:23
@spacedmonkey
Copy link
Copy Markdown
Contributor Author

spacedmonkey commented Oct 5, 2020

@swissspidy Any chance of a review again?

swissspidy
swissspidy reviewed Oct 5, 2020
View reviewed changes
swissspidy
swissspidy reviewed Oct 5, 2020
View reviewed changes
swissspidy
swissspidy approved these changes Oct 5, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with nits

@swissspidy
Copy link
Copy Markdown
Collaborator

swissspidy commented Oct 6, 2020

FYI, Dashboard integration tests are also failing on main. Known issue as per https://xwp.slack.com/archives/CCCAUAH6F/p1601955965079000

@swissspidy swissspidy merged commit df92161 into main Oct 6, 2020
@swissspidy swissspidy deleted the fix/publisher-logo branch October 6, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

Type: Infrastructure Changes impacting testing infrastructure or build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove fallback publisher logo

2 participants

@spacedmonkey @swissspidy