Skip to content

chore: fix the broken integration tests #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plumpy merged 1 commit into from
Nov 6, 2025
Merged

chore: fix the broken integration tests #9904

plumpy merged 1 commit into from
Nov 6, 2025
+8 −8

Conversation

@plumpy
Copy link
Collaborator

@plumpy plumpy commented Nov 6, 2025 •
edited
Loading

The OpenJDK containers were removed from dockerhub.

@plumpy plumpy requested a review from a team as a code owner November 6, 2025 16:49
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 6, 2025

Summary of Changes

Hello @plumpy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a broken integration test by updating the base Java Development Kit (JDK) image used in its pom.xml configuration. The openjdk:8 image is no longer available, so it has been replaced with openjdk:25 to ensure the test can execute successfully and maintain the stability of the test suite.

Highlights

  • Integration Test Fix: The base Docker image for an integration test has been updated from openjdk:8 to openjdk:25 to resolve a broken test caused by the unavailability of the older image.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

alphanota
alphanota previously approved these changes Nov 6, 2025
View reviewed changes
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the base image for a Java integration test from openjdk:8 to openjdk:25 to fix a broken test, as the older image is no longer available. My main feedback is to use a stable Long-Term Support (LTS) version of OpenJDK, such as openjdk:21, instead of an early-access version like openjdk:25. This will improve the stability and long-term maintainability of the test. I've also noticed that other pom.xml files in the examples/ directory still reference the openjdk:8 image. These will likely fail as well and should probably be updated in this or a follow-up PR.

@plumpy
chore: fix the broken integration test
a2c8a7b 
It looks like openjdk:8 is no longer available. (Fair, even Java 11 has
been out for 7 years now.)
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Nov 6, 2025
@plumpy plumpy changed the title chore: fix the broken integration test chore: fix the broken integration tests Nov 6, 2025
@plumpy plumpy requested a review from alphanota November 6, 2025 18:53
@plumpy plumpy enabled auto-merge (squash) November 6, 2025 18:53
@plumpy plumpy merged commit 86080e7 into GoogleContainerTools:main Nov 6, 2025
11 checks passed
@plumpy plumpy deleted the openjdk_test branch November 6, 2025 19:07
@plumpy plumpy mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alphanota alphanota alphanota approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plumpy @alphanota