Convert jib.*.auth.username and jib.*.auth.password to properties#2906
Merged
chanseokoh merged 1 commit intoGoogleContainerTools:masterfrom Dec 3, 2020
dubinsky:master
Merged
Convert jib.*.auth.username and jib.*.auth.password to properties#2906chanseokoh merged 1 commit intoGoogleContainerTools:masterfrom dubinsky:master
chanseokoh merged 1 commit intoGoogleContainerTools:masterfrom
dubinsky:master
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@googlebot I signed it! |
Member
|
Sorry for the delay. I'm trying to run some integration tests locally on this branch but having some issue. |
Contributor
Author
No worries; can I help? |
chanseokoh
approved these changes
Dec 3, 2020
Member
chanseokoh
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for your contribution!
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2905
The following are now properties and not plain strings: