Conversation
chanseokoh
reviewed
Sep 18, 2020
| def additionalTag = System.getProperty("_ADDITIONAL_TAG") | ||
| if (additionalTag != null && !additionalTag.isEmpty()) { | ||
| jib.to.tags = [System.getProperty("_ADDITIONAL_TAG")] | ||
| jib.to.tags = [System.getProperty("_ADDITIONAL_TAG")] as Set |
Member
There was a problem hiding this comment.
Hmm... I think we should keep it backward-compatible. It will be common to use a list. I suspect that adding another setTags() stops Gradle from auto-casting it to a Set. @loosebazooka maybe we need to add a setTags(List) too?
Contributor
Author
There was a problem hiding this comment.
You're absolutely right. I just realized that this change doesn't really solve the backward-compatibility issue.
chanseokoh
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, this integration test was failing. This PR serves as a follow-up to #2739.