Add a 'nobody' user and group#335
Add a 'nobody' user and group#335chanseokoh merged 1 commit intoGoogleContainerTools:masterfrom thockin:master
Conversation
|
Please fix the formatting error: #291 (comment) Let's use the number 65534 instead of 65535. That's the number on my machine, and it is only beneficial to avoid 65535: https://superuser.com/questions/706338/why-on-some-systems-max-uid-gid-is-65534-an-not-65535 |
|
I have changed numbers and run buildifier. Separate bug: When I run When I run buildifier.sh is checking for a non-success error code, so it will never work. As a casual contributor, it's scary to be told "Go wget and run this binary". It would be nicer if that was more transparent (and in fact if it "just worked" from HEAD -- even a |
|
Seems like a test failure. Please fix.
Probably there's something broken about that. Please file a bug. I maintain Java part of distroless, so I honestly don't know very well about the buildifier stuff. |
|
test fixed, I think.
…On Mon, Mar 25, 2019 at 11:15 AM Chanseok Oh ***@***.***> wrote:
Seems like a test failure. Please fix.
Separate bug:
Probably there's something broken about that. Please file a bug. I maintain Java part of distroless, so I honestly don't know very well about the buildifier stuff.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
base/testdata/base.yaml
Outdated
| - name: 'known users' | ||
| path: '/etc/passwd' | ||
| expectedContents: ['^root:x:0:0:user:/home:/bin/bash\n$'] | ||
| expectedContents: ['^root:x:0:0:user:/home:/bin/bash\nnobody:x:65534:65534:user:/hom:/bin/bash\n$'] |
There was a problem hiding this comment.
Test still failing. Probably /hom: --> /home:.
|
all green |
|
@thockin there's an image with this change published here: gcr.io/distroless/base:5eb0f8a01ed8046cefc3a7ca9cf5b95bad296dcf I can tag it as latest soon |
|
Thanks all!
…On Mon, Mar 25, 2019 at 12:43 PM dlorenc ***@***.***> wrote:
@thockin <https://github.com/thockin> there's an image with this change
published here:
gcr.io/distroless/base:5eb0f8a01ed8046cefc3a7ca9cf5b95bad296dcf
I can tag it as latest soon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVDfM2wjN9JFM5pbmqJTGr2dwwydUks5vaSa_gaJpZM4cHTJ3>
.
|
Fixes #332