Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

Fix compute instance iam asset name#905

Merged
modular-magician merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-magician:downstream-pr-bf766eb3af704fbfa4ad8dded9bce5b1770385fe
Aug 9, 2022
Merged

Fix compute instance iam asset name#905
modular-magician merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-magician:downstream-pr-bf766eb3af704fbfa4ad8dded9bce5b1770385fe

Conversation

@modular-magician

Copy link
Copy Markdown
Contributor

Fix compute instance iam asset name

Asset name was expecting instance, but compute instance iam uses instance_name as attribute name.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6390

* Fix compute instance iam asset name

* Use parent resource name for asset name if not empty

* fix iam policy test case

* revert a new file

* use parent_resource_name

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested review from a team and iyabchen and removed request for a team August 9, 2022 20:40
@modular-magician modular-magician merged commit 881c4a5 into GoogleCloudPlatform:main Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant