Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

Fetch project with storage API for storage bucket#1128

Merged
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
iyabchen:storage-iam-project
Nov 29, 2022
Merged

Fetch project with storage API for storage bucket#1128
ScottSuarez merged 1 commit into
GoogleCloudPlatform:mainfrom
iyabchen:storage-iam-project

Conversation

@iyabchen

Copy link
Copy Markdown
Contributor

#1092

Fetch project with storage API if cai Resource Data does not contain project. Falls back to provider config project if fetching from API fails.

Thought about adding an intergration test, but it requires the bucket exist to make it work, so just added a unit test.

@iyabchen iyabchen requested review from a team and melinath and removed request for a team November 16, 2022 18:13
@melinath melinath requested review from a team, ScottSuarez and shuyama1 and removed request for a team, melinath and shuyama1 November 22, 2022 21:33
@ScottSuarez ScottSuarez merged commit 7919abf into GoogleCloudPlatform:main Nov 29, 2022
@ScottSuarez

Copy link
Copy Markdown
Contributor

Thanks for the work iris ^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants