Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

tfv: Fix GetOk field name in hand written iam files#1112

Merged
modular-magician merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-magician:downstream-pr-31a061c2ab2dcb9c8d17a77281032681cc2ad305
Nov 11, 2022
Merged

tfv: Fix GetOk field name in hand written iam files#1112
modular-magician merged 1 commit into
GoogleCloudPlatform:mainfrom
modular-magician:downstream-pr-31a061c2ab2dcb9c8d17a77281032681cc2ad305

Conversation

@modular-magician

Copy link
Copy Markdown
Contributor

b/255831148
terraform validator: GetOk() function should not have {{}} within the parameter.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6745

* tfv: Fix GetOk field name in hand written iam files

* tfv: Add unit test for IAM FetchFullResource

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested review from a team and iyabchen and removed request for a team November 11, 2022 19:23
@modular-magician modular-magician merged commit d6ae502 into GoogleCloudPlatform:main Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant