Skip to content

Feat: Onboard New York Taxi Trips dataset#381

Merged
adlersantos merged 12 commits into
GoogleCloudPlatform:mainfrom
nlarge-google:new_york_taxi_trips
Jun 16, 2022
Merged

Feat: Onboard New York Taxi Trips dataset#381
adlersantos merged 12 commits into
GoogleCloudPlatform:mainfrom
nlarge-google:new_york_taxi_trips

Conversation

@nlarge-google

@nlarge-google nlarge-google commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Description

Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g. datasets/google_trends

Resubmitted because of loss of my original fork.

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/new_york_taxi_trips and nothing outside of that directory

@nlarge-google nlarge-google self-assigned this Jun 14, 2022
@nlarge-google

Copy link
Copy Markdown
Contributor Author

@adlersantos Please review! Thanks.

Comment thread datasets/new_york_taxi_trips/pipelines/new_york_taxi_trips/pipeline.yaml Outdated
Comment thread datasets/new_york_taxi_trips/pipelines/new_york_taxi_trips/pipeline.yaml Outdated
Comment thread datasets/new_york_taxi_trips/pipelines/new_york_taxi_trips/pipeline.yaml Outdated
@@ -0,0 +1,34 @@
/**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file should be gone.

@@ -0,0 +1,34 @@
/**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too should be gone. So all *_pipeline.tf files must be replaced by the new_york_taxi_trips_pipeline.tf file.

@adlersantos adlersantos changed the title Feat: Onboard New York Taxi Trips Dataset Feat: Onboard New York Taxi Trips dataset Jun 16, 2022
@adlersantos adlersantos merged commit 897ac3f into GoogleCloudPlatform:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants