Skip to content

feat: Onboard City Health Dashboard dataset#374

Merged
adlersantos merged 7 commits into
GoogleCloudPlatform:mainfrom
nlarge-google:city_health_dashboard
Jun 10, 2022
Merged

feat: Onboard City Health Dashboard dataset#374
adlersantos merged 7 commits into
GoogleCloudPlatform:mainfrom
nlarge-google:city_health_dashboard

Conversation

@nlarge-google

@nlarge-google nlarge-google commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

Description

Fixes to existing production dataset

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/city_health_dashboard and nothing outside of that directory
  • I'm refactoring or cleaning up some code

@nlarge-google nlarge-google requested a review from adlersantos June 6, 2022 20:48
@nlarge-google

Copy link
Copy Markdown
Contributor Author

@adlersantos @happyhuman Please Review. Thanks.

@adlersantos adlersantos changed the title Feat: Onboard City health dashboard dataset feat: Onboard City Health Dashboard dataset Jun 10, 2022
table = client.get_table(table_ref)
table_exists_id = table.table_id
logging.info(f"Table {table_exists_id} currently exists.")
if drop_table:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revise the pipeline to not drop tables in the future.

@adlersantos adlersantos added revision: pipeline Revise a pipeline or dataset data onboarding Onboard a dataset or submit a pipeline bug Something isn't working or open a bugfix labels Jun 10, 2022
@adlersantos adlersantos merged commit c7cd9dd into GoogleCloudPlatform:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working or open a bugfix data onboarding Onboard a dataset or submit a pipeline revision: pipeline Revise a pipeline or dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants