Skip to content

fix: Revised COVID-19 Google Mobility dataset#363

Merged
adlersantos merged 5 commits into
GoogleCloudPlatform:mainfrom
nlarge-google:covid19_google_mobility
May 27, 2022
Merged

fix: Revised COVID-19 Google Mobility dataset#363
adlersantos merged 5 commits into
GoogleCloudPlatform:mainfrom
nlarge-google:covid19_google_mobility

Conversation

@nlarge-google

@nlarge-google nlarge-google commented May 24, 2022

Copy link
Copy Markdown
Contributor

Description

This DAG is failing in production and so this PR attempts to resolve the issues by both correcting the code and making the code consistent with existing implementations on this project.

Dataset: covid19_google_mobility
pipeline/s: mobility_report

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/covid19_google_mobility> and nothing outside of that directory
  • I'm refactoring or cleaning up some code

@nlarge-google nlarge-google self-assigned this May 24, 2022
@adlersantos adlersantos changed the title Feat: Onboard Covid19 google mobility dataset (fixes/re-engineer) Feat: Revised COVID-19 Google Mobility dataset May 27, 2022
@adlersantos adlersantos self-requested a review May 27, 2022 18:00
@adlersantos adlersantos changed the title Feat: Revised COVID-19 Google Mobility dataset fix: Revised COVID-19 Google Mobility dataset May 27, 2022
@adlersantos adlersantos added bug Something isn't working or open a bugfix cleanup Cleanup or refactor code revision: pipeline Revise a pipeline or dataset labels May 27, 2022
Comment thread datasets/covid19_google_mobility/pipelines/mobility_report/pipeline.yaml Outdated
Comment thread datasets/covid19_google_mobility/pipelines/mobility_report/pipeline.yaml Outdated
@nlarge-google

Copy link
Copy Markdown
Contributor Author

@adlersantos Changes complete. Please review.

@adlersantos adlersantos merged commit ddd3dac into GoogleCloudPlatform:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working or open a bugfix cleanup Cleanup or refactor code revision: pipeline Revise a pipeline or dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants