feat: Onboard NOAA dataset#353
Merged
Merged
Conversation
happyhuman
reviewed
May 9, 2022
| int_date_list: typing.List[str], | ||
| gen_location_list: dict, | ||
| ) -> None: | ||
| if pipeline_name == "GHCND by year": |
Contributor
There was a problem hiding this comment.
Perhaps "GHCND by year" can be defined as a constant at the top of this file (or better yet, read from a yaml file). Same goes for other similar cases.
Contributor
Author
There was a problem hiding this comment.
What added value would that bring to the code? What would the variable be called?
adlersantos
requested changes
Jun 8, 2022
adlersantos
left a comment
Member
There was a problem hiding this comment.
Just fix the indentation on the JSON files and we're good to go.
Contributor
Author
|
@adlersantos Fixes are complete as per your request. Testing showed one other issue which is now resolved. Please Review. Thanks! |
adlersantos
approved these changes
Jun 10, 2022
| depends_on_past: False | ||
| start_date: '2021-03-01' | ||
| max_active_runs: 1 | ||
| schedule_interval: "0 1 0 0 6" |
Member
There was a problem hiding this comment.
Let's add a comment for clarity.
Suggested change
| schedule_interval: "0 1 0 0 6" | |
| schedule_interval: "0 1 0 0 6" # Every Saturday at 1am server time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ghcnd_by_year
ghcnd_countries
ghcdn_inventory
ghcnd_states
ghcnd_stations
gsod_stations
ghcnd_hurricanes
lightning_strikes_by_year
Checklist
datasets/noaaand nothing outside of that directory