Skip to content

Feat: Migrate the World Bank datasets x 3 from Xenon#506

Merged
nlarge-google merged 5 commits into
GoogleCloudPlatform:mainfrom
Naveen130:world_bank
Oct 17, 2022
Merged

Feat: Migrate the World Bank datasets x 3 from Xenon#506
nlarge-google merged 5 commits into
GoogleCloudPlatform:mainfrom
Naveen130:world_bank

Conversation

@Naveen130

@Naveen130 Naveen130 commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Description

This PR makes changes to these 3 existing datasets

  • world_bank_health_population
  • world_bank_intl_debt
  • world_bank_intl_education

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved

Code cleanup or refactoring

  • I'm refactoring or cleaning up some code

@Naveen130 Naveen130 self-assigned this Oct 10, 2022
@Naveen130

Copy link
Copy Markdown
Contributor Author

@nlarge-google As discussed, I have made the changes in a single PR for the remaining World Bank datasets.

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes necessary. Great job though!

@Naveen130

Copy link
Copy Markdown
Contributor Author

@nlarge-google I have taken care of your comments. You may review.

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@nlarge-google nlarge-google merged commit 65295d0 into GoogleCloudPlatform:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants