Skip to content

feat: Onboard FDIC dataset#495

Merged
nlarge-google merged 10 commits into
GoogleCloudPlatform:mainfrom
gkodukula:fdic
Oct 14, 2022
Merged

feat: Onboard FDIC dataset#495
nlarge-google merged 10 commits into
GoogleCloudPlatform:mainfrom
gkodukula:fdic

Conversation

@gkodukula

@gkodukula gkodukula commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Description

Dataset: FDIC

  • Locations
  • Institutions

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved

Use the sections below based on what's applicable to your PR and delete the rest:

Feature

  • I'm adding or editing a feature
  • I have updated the README accordingly
  • I have added/revised tests for the feature

Data Onboarding

  • I'm adding or editing a dataset
  • The Google Cloud Datasets team is aware of the proposed dataset
  • I put all my code inside datasets/fdic and nothing outside of that directory

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job. Just need to make the respective changes and we are good to go.

Comment thread datasets/fdic/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/fdic/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/fdic/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/fdic/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/fdic/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@nlarge-google nlarge-google merged commit e20e157 into GoogleCloudPlatform:main Oct 14, 2022
@nlarge-google

Copy link
Copy Markdown
Contributor

Merged and deployed to production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants