Skip to content

Feat: Onboard Fashion MNIST dataset#387

Merged
adlersantos merged 7 commits into
GoogleCloudPlatform:mainfrom
gkodukula:fashion_mnist
Jul 11, 2022
Merged

Feat: Onboard Fashion MNIST dataset#387
adlersantos merged 7 commits into
GoogleCloudPlatform:mainfrom
gkodukula:fashion_mnist

Conversation

@gkodukula

@gkodukula gkodukula commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Description

Pipelines included:

  • fashion_mnist

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside fashion_mnist/<fashion_mnist> and nothing outside of that directory
  • I'm refactoring or cleaning up some code

)

(
download_and_process_source_zip_file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a different naming convention for these nodes, other than using _2, _3, _4? Maybe a descriptive name of what each node does?

@adlersantos adlersantos changed the title Feat: Onboarding Fashion mnist dataset Feat: Onboard Fashion MNIST dataset Jun 22, 2022

@adlersantos adlersantos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for KPods, just use the Bash operator to download the files into the Composer bucket via the local Airflow directory, then copy to the destination bucket.

See here for an explanation: https://cloud.google.com/composer/docs/concepts/cloud-storage

Comment thread datasets/fashion_mnist/pipelines/fashion_mnist/pipeline.yaml Outdated
@adlersantos adlersantos merged commit 91b7f6a into GoogleCloudPlatform:main Jul 11, 2022
vijay-google pushed a commit to vijay-google/public-datasets-pipelines that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants