Skip to content

feat: Revise Google Political Ads due to new dataset version#317

Merged
happyhuman merged 3 commits into
mainfrom
google-political-ads
Mar 24, 2022
Merged

feat: Revise Google Political Ads due to new dataset version#317
happyhuman merged 3 commits into
mainfrom
google-political-ads

Conversation

@adlersantos

@adlersantos adlersantos commented Mar 24, 2022

Copy link
Copy Markdown
Member

Description

This PR revises the google_political_ads pipeline for the upcoming version of their dataset. I have also simplified multiple DAGs (all doing the same transforms, differing only in schema) into a single DAG.

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • I have updated the README accordingly
    • I have added tests for the feature
  • I'm adding or editing a dataset
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside datasets/<DATASET_NAME> and nothing outside of that directory
  • I'm adding/editing documentation
  • I'm submitting a bugfix
    • I have added tests to my bugfix (see the tests folder)
  • I'm refactoring or cleaning up some code

@adlersantos adlersantos requested review from happyhuman and leahecole and removed request for leahecole March 24, 2022 15:03
@happyhuman happyhuman merged commit 6ffb0d0 into main Mar 24, 2022
@happyhuman happyhuman deleted the google-political-ads branch March 24, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants