Skip to content

feat: Onboard Open Targets Platform dataset#313

Merged
adlersantos merged 24 commits into
GoogleCloudPlatform:mainfrom
gkodukula:open_targets_platform
Apr 29, 2022
Merged

feat: Onboard Open Targets Platform dataset#313
adlersantos merged 24 commits into
GoogleCloudPlatform:mainfrom
gkodukula:open_targets_platform

Conversation

@gkodukula

@gkodukula gkodukula commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

Description

Pipelines included:

  • open_targets,platform

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved
  • I'm adding or editing a feature
    • The Google Cloud Datasets team is aware of the proposed dataset
    • I put all my code inside open_targets/platform and nothing outside of that directory
  • I'm refactoring or cleaning up some code

@gkodukula gkodukula changed the title Open targets platform feat: Onboard Open Targets Platform dataset Mar 21, 2022
@adlersantos

Copy link
Copy Markdown
Member

Your PR shouldn't include code related to the nasa_wildfire dataset

Comment thread datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated
Comment thread datasets/nasa_wildfire/pipelines/_images/run_csv_transform_kub/csv_transform.py Outdated

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change

Comment thread datasets/open_targets/pipelines/dataset.yaml Outdated
Comment thread datasets/open_targets/pipelines/_images/copy_bq_datasets/script.py Outdated
Comment thread datasets/open_targets/pipelines/_images/copy_bq_datasets/script.py Outdated
Comment thread datasets/open_targets/pipelines/copy_platform_data/pipeline.yaml Outdated

@adlersantos adlersantos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes to use proper namespacing for the Airflow variables. Will merge when the tests pass

@adlersantos adlersantos merged commit c5adce6 into GoogleCloudPlatform:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants