Skip to content

feat: Retrieve Composer bucket name when deploying DAGs#312

Merged
adlersantos merged 10 commits into
GoogleCloudPlatform:mainfrom
arjunsgill:no-gcs-bucket-param
Apr 8, 2022
Merged

feat: Retrieve Composer bucket name when deploying DAGs#312
adlersantos merged 10 commits into
GoogleCloudPlatform:mainfrom
arjunsgill:no-gcs-bucket-param

Conversation

@arjunsgill

Copy link
Copy Markdown
Contributor

Description

Note: If you are adding or editing a dataset, please specify the dataset folder involved, e.g. datasets/google_trends

  • tidied up readme, to make it more consistent remove $ in the beginning some of the bash scripts
  • added a function to automatically retrieve the gcs bucket via the composer api if it is not specified

Checklist

Note: If an item applies to you, all of its sub-items must be fulfilled

  • (Required) This pull request is appropriately labeled
  • I'm adding/editing documentation
  • I'm refactoring or cleaning up some code

@arjunsgill arjunsgill changed the title added function to retrieve composer gcs bucket without it being specified and updated readme Fix: added function to retrieve composer gcs bucket without it being specified and updated readme Mar 21, 2022
@arjunsgill arjunsgill changed the title Fix: added function to retrieve composer gcs bucket without it being specified and updated readme feat: added function to retrieve composer gcs bucket without it being specified and updated readme Mar 21, 2022
@adlersantos adlersantos self-requested a review March 24, 2022 14:17
@adlersantos adlersantos requested a review from leahecole March 25, 2022 19:26
@adlersantos adlersantos changed the title feat: added function to retrieve composer gcs bucket without it being specified and updated readme feat: Retrieve Composer bucket without it being required when deploying DAGs Mar 25, 2022

@adlersantos adlersantos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes but overall LGTM!

Comment thread Pipfile Outdated
Comment thread Pipfile Outdated
Comment thread scripts/deploy_dag.py Outdated
@arjunsgill arjunsgill requested a review from adlersantos April 8, 2022 14:55
@adlersantos adlersantos changed the title feat: Retrieve Composer bucket without it being required when deploying DAGs feat: Retrieve Composer bucket name when deploying DAGs Apr 8, 2022
@adlersantos adlersantos merged commit 220f1d5 into GoogleCloudPlatform:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants