Conversation
Signed-off-by: bwplotka <bwplotka@google.com>
TheSpiritXIII
approved these changes
Jun 12, 2024
pintohutch
reviewed
Jun 14, 2024
| // Asserting there is actually no GCE underneath. | ||
| if metadata.OnGCE() { | ||
| t.Fatal("This test assumes we don't run on GCP") | ||
| t.Skip("This test can't run on GCP or Cloudtop; we expect no metadata server.") |
Collaborator
There was a problem hiding this comment.
Hrm - it should work on Cloudtop:
$ nslookup metadata.google.internal
Server: 127.0.0.1
Address: 127.0.0.1#53
Non-authoritative answer:
Name: metadata.google.internal
Address: 169.254.169.254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out @TheSpiritXIII suggestion was worth doing 🙃