Move e2e test files into subpackage#55
Merged
aabmass merged 1 commit intoGoogleCloudPlatform:mainfrom Sep 4, 2024
Merged
Conversation
Before I add the docker test code from GoogleCloudPlatform/opentelemetry-operations-java#364 to this repo, I wanted to move the e2e test runner code (which is separate to a subpackage). This makes it more explicit what is used for what and simplifies CI a bit.
dashpole
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I add the docker test code from GoogleCloudPlatform/opentelemetry-operations-java#364 to this repo, I wanted to move the e2e test runner code (which is totally separate) to a subpackage. This makes it more explicit what is used for what and simplifies CI a bit.
Also added a
go:build e2eto the e2e test cases to avoid running them with "regular" unit tests in this repo.