Skip to content

feat(auth): samples for auth#2759

Closed
FrodoTheTrue wants to merge 8 commits intomainfrom
add-auth-samples
Closed

feat(auth): samples for auth#2759
FrodoTheTrue wants to merge 8 commits intomainfrom
add-auth-samples

Conversation

@FrodoTheTrue
Copy link
Copy Markdown
Contributor

@FrodoTheTrue FrodoTheTrue commented Sep 16, 2022

No description provided.

@FrodoTheTrue FrodoTheTrue requested a review from a team as a code owner September 16, 2022 10:25
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 16, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Sep 16, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@FrodoTheTrue FrodoTheTrue mentioned this pull request Sep 16, 2022
Merged
4 tasks
@kweinmeister kweinmeister requested a review from a team as a code owner October 11, 2022 22:00
@grayside
Copy link
Copy Markdown
Collaborator

grayside commented Nov 8, 2022

Is this PR migrating samples from https://github.com/googleapis/google-auth-library-nodejs/tree/main/samples? If so could we follow the revised process to keep the Git commit history?

@rsamborski
Copy link
Copy Markdown
Member

rsamborski commented Nov 18, 2022

@Shnatsel Can you PTAL and get this merged?
@Sita04 can provide more context

ace-n
ace-n suggested changes Nov 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ace-n ace-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting @grayside's comment:

Is this PR migrating samples from https://github.com/googleapis/google-auth-library-nodejs/tree/main/samples? If so could we follow the revised process to keep the Git commit history?

@FrodoTheTrue FYI: it's probably easiest to close this PR and create a new one.

(Feel free to DM me internally or post in the (internal) migration chat channel if any of this is unclear! 😃)

@kweinmeister kweinmeister requested a review from a team as a code owner December 19, 2022 18:36
@Shnatsel
Copy link
Copy Markdown
Contributor

Shnatsel commented Dec 23, 2022

The samples have instead been added to the client library repository. Since the client library is not automatically generated, there are currently no plans to move the samples to nodejs-docs-samples. Closing.

@Shnatsel Shnatsel closed this Dec 23, 2022
@pattishin pattishin deleted the add-auth-samples branch June 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ace-n ace-n ace-n requested changes

@danielbankhead danielbankhead danielbankhead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Shnatsel Shnatsel

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@FrodoTheTrue @grayside @rsamborski @Shnatsel @ace-n @danielbankhead @kweinmeister