Skip to content

tfv: Fix empty folder ID causing error for folder_iam#6623

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
iyabchen:fix-empty-folder-iam
Sep 29, 2022
Merged

tfv: Fix empty folder ID causing error for folder_iam#6623
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
iyabchen:fix-empty-folder-iam

Conversation

@iyabchen

@iyabchen iyabchen commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Fix empty folder ID causing error for folder_iam resource
Related to GoogleCloudPlatform/terraform-validator#999

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@modular-magician

modular-magician commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

@iyabchen iyabchen requested review from melinath and removed request for ScottSuarez September 29, 2022 15:46
@modular-magician

modular-magician commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Validator: Diff ( 6 files changed, 220 insertions(+))

melinath
melinath approved these changes Sep 29, 2022
View reviewed changes
Comment thread mmv1/third_party/validator/tests/data/example_folder_iam_member_empty_folder.json
@melinath

melinath commented Sep 29, 2022

Copy link
Copy Markdown
Member

merging since there are no changes to the provider and tfv tests are passing.

@melinath melinath merged commit b807824 into GoogleCloudPlatform:main Sep 29, 2022
@modular-magician modular-magician mentioned this pull request Sep 29, 2022
Merged
5 tasks
@modular-magician

modular-magician commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2192
Passed tests 1939
Skipped tests: 240
Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRouterInterface_basic|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeFirewallPolicy_update|TestAccComputeFirewallPolicyRule_update

@modular-magician

modular-magician commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melinath melinath melinath approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iyabchen @modular-magician @melinath