Skip to content

Add ancestors into test comparison#6091

Merged
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
iyabchen:ancestors
Jun 1, 2022
Merged

Add ancestors into test comparison#6091
melinath merged 2 commits into
GoogleCloudPlatform:mainfrom
iyabchen:ancestors

Conversation

@iyabchen

Copy link
Copy Markdown
Contributor

GoogleCloudPlatform/terraform-validator#105
Adding ancestors into Asset, and update test comparison logic to derive ancestors from ancestry path for the expected object.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@melinath

melinath commented Jun 1, 2022

Copy link
Copy Markdown
Member

/gcbrun

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - matches downstream.

@melinath melinath merged commit cd20c0a into GoogleCloudPlatform:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants